refactor(selection): new approach#700
Merged
harbournick merged 2 commits intodevelopfrom Jul 24, 2025
Merged
Conversation
artem-harbour
previously requested changes
Jul 24, 2025
Contributor
artem-harbour
left a comment
artem-harbour
left a comment
There was a problem hiding this comment.
Added a comment to fix.
harbournick
dismissed
artem-harbour’s stale review
I added a commit to fix this - nice catch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @harbournick! I decided to move to different selection approach and try to use as much native selection as possible to avoid bugs and issues. Custom selection will jump in when toolbar item is clicked (to make it unified for the whole toolbar) and will have a slightly different colour from the native one. Could you please check this one and let me know what do you think
cc @artem-harbour